Avoid garbage references when DNS resolution rejects on legacy PHP <= 5.6 #133
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jul 10, 2019
clue
changed the title
|
For the reference: I've verified this actually fixes the build error for the downstream socket component (https://travis-ci.org/reactphp/socket/builds/556729141) by applying this version manually: # composer.json.patch
{
"require": {
"react/dns": "dev-legacy-garbage as 0.4.19"
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/clue/dns"
}
],
"config": {
"platform": {
"php": "5.6.30"
}
}
}
In other words: Once this PR is in and tagged as v0.4.19, the upstream component will build just fine again without any modification 👍 |
These garbage references only show up when a DNS lookup rejects with an Exception on legacy PHP <= 5.6. These issues have been fixed upstream in the Promise component for current PHP versions with https://github.com/reactphp/promise/releases/tag/v2.6.0 but this PR explicitly unsets known garbage references to avoid unexpected memory growth on legacy PHP versions. The downstream Socket component implicitly depends on this because its test suite currently fails. This changeset can be considered a new feature in this component which fixes a bug in the test suite of a downstream component.
jsor
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These garbage references only show up when a DNS lookup rejects with an
Exception on legacy PHP <= 5.6. These issues have been fixed upstream in
the Promise component for current PHP versions with
https://github.com/reactphp/promise/releases/tag/v2.6.0 but this PR
explicitly unsets known garbage references to avoid unexpected memory
growth on legacy PHP versions.
The downstream Socket component implicitly depends on this because its
test suite currently fails. This changeset can be considered a new
feature in this component which fixes a bug in the test suite of a
downstream component.
Accordingly to the roadmap (#128) we planned to stop the v0.4.x series, but I consider this to be a notable issue that warrants a v0.4.19 release. Once accepted, I will manually merge this into the current
masterbranch targeting the upcomingv1.0.0milestone.Builds on top of #125 and #129
Refs #118